search

fabian-lauer / dbus-shelly-3em-smartmeter

Integrate Shelly 3EM smart meter into Victron Energies Venus OS
125 stars 55 forks source link

Automatic logfile rotation seems to be missing #69

Open mpvader opened 3 months ago

mpvader commented 3 months ago

Hi!

as dbus-shelly is now, I expect every user using it will run into trouble (full data partition, a really bad situation) at some point.

see see https://github.com/henne49/dbus-opendtu/issues/173 for how I recommend to fix it.

Matthijs / Victron

mpvader commented 3 months ago

Hey @Kotty666 , since you worked on this before, can I interest you in getting this fixed?

many people are copying this repo, and it is causing issue for us.

50Mb is also too much.

please make the code write to stdout instead of making its own log file - see above link.

Kotty666 commented 3 months ago

@mpvader should be possible just done this few days ago at my dbus-growatt-shinex repository. But the interesting thing would be if @fabian-lauer had enough time to merge the request.

Kotty666 commented 3 months ago

I've changed the needed stuff and createt a PR (#71 )