Adressing the issues opened during JOSS review

fabian-sp / GGLasso

A Python package for General Graphical Lasso computation

MIT License

30 stars 14 forks source link

Adressing the issues opened during JOSS review #29

Closed fabian-sp closed 2 years ago

fabian-sp commented 2 years ago

Issues:

Escaping math operators in docstrings, see https://github.com/fabian-sp/GGLasso/issues/27

fabian-sp commented 2 years ago

I added the verbose option for .solve() and replaced print with warnings. I added a seed option to the sampling so now every experiment can be fully seeded.

fabian-sp commented 2 years ago

I added an assertion for the SGL case in test_problem