search

fabian-sp / GGLasso

A Python package for General Graphical Lasso computation
MIT License
30 stars 14 forks source link

NumPy Versioning Issue #42

Closed Bpoole908 closed 11 months ago

Bpoole908 commented 11 months ago

It looks like np.float is/has been deprecated in NumPy. Currently, GGLasso requires any version of NumPy >= 1.17.3. However, this breaks for versions of NumPy > 1.22.0 where np.float has been fully removed. Maybe this should be considered in the requirements or np.float usage should be updated?

fabian-sp commented 11 months ago

Thanks for pointing this out. I will replace np.float by np.float64,..

Somehow in Colab, if I install a numpy version > 1.22.0 it still seems to work though (I only get the DeprecationWarning).

Bpoole908 commented 11 months ago

There could be additional versions that still throw the DeprecationWarning. I believe I originally observed that 1.25.2 throws a full error. I didn't test every version in-between sadly. I found 1.22.0 worked and went with that for now.

fabian-sp commented 11 months ago

I update the package (to version 0.1.10) and it should now also work with the newest versions of numpy.