search

fabian-sp / GGLasso

A Python package for General Graphical Lasso computation
MIT License
30 stars 14 forks source link

Test single gl #5

Closed Vlasovets closed 3 years ago

Vlasovets commented 3 years ago

comparison tests between glasso, sklearn and lvsglasso

fabian-sp commented 3 years ago

Hi Oleg, some comments:

1) The merge conflict on test_single_GL is probably because I pushed something there on Friday but I just added time measurements. So you should be able resolve the conflict easily. 2) You also pushed .idea files (which come from PyCharm I guess). Can you remove them again? You can also add it to the gitignore in order to avoid this in the future. 3) Regarding the lvsglasso submodule: did you find a way of seeing their formulation equivalent to ours? Because if we cannot compare them properly, I would simply remove all lvsglasso files and also the respective test.