search

fabiangreffrath / crispy-doom

Crispy Doom is a limit-removing enhanced-resolution Doom source port based on Chocolate Doom.
https://fabiangreffrath.github.io/crispy-homepage
GNU General Public License v2.0
808 stars 132 forks source link

Make full chainsaw sound toggable #116

Closed Danfun64 closed 8 years ago

Danfun64 commented 8 years ago

It's an interesting feature, but it makes switching between other source ports which lack this feature awkward.

plumsinus commented 8 years ago

I doubt very much that Fabian will want to make a new option just for this.

Any chance you would settle for a shortened chainsaw sound that gets auto-loaded with Crispy Doom, if I made you one?

plumsinus commented 8 years ago

Here's a wad with a short chainsaw, put it in the same directory as crispy-doom.cfg. (Rename it if you've already got a preload0.wad, eg. preload1.wad or whatever.) preload0.zip

There's a slight gap between the end of the sawup sound and the start of the chainsaw rumble, regardless of whether you use this file or not. Maybe that could be fixed?

fabiangreffrath commented 8 years ago

switching between other source ports

Thou shalt have no other source ports before me. ;)

No, seriously, at first I was also skeptical. But once I got used to it, I couldn't stand the interrupted sounds of other source ports anymore. And I think the PWAD @plumsinus provided is a nice workaround for those who refuse this feature at all cost. Pretty sure there won't be a switch in the menus for this.

Danfun64 commented 8 years ago

@plumsinus freedoom, chex quest, hacx versions needed

plumsinus commented 8 years ago

@fabiangreffrath Is there a way to automatically choose which preload wads to used, based on the other iwads that @Danfun64 listed?

Danfun64 commented 8 years ago

There's also the matter of when pwads replace the sound...

SoDOOManiac commented 8 years ago

Thou shalt have no other source ports before me. ;)

Ahahahaha %)))))

There's a slight gap between the end of the sawup sound and the start of the chainsaw rumble, regardless of whether you use this file or not. Maybe that could be fixed?

I'd also like to have this fixed if it's possible.

fabiangreffrath commented 8 years ago

I'll consider adding a single switch to enable/disable the chainsaw sound and the other sound extensions.

SoDOOManiac commented 8 years ago

Nice) I'd like to remind of this. Any chance of fixing it?

There's a slight gap between the end of the sawup sound and the start of the chainsaw rumble, regardless of whether you use this file or not. Maybe that could be fixed?

fabiangreffrath commented 8 years ago

No, sorry. The sounds are played in full length until the end. If there is a gap at the end of the original sound, there is nothing I can (or am going to) do about this.

plumsinus commented 8 years ago

If there is a gap at the end of the original sound, there is nothing I can (or am going to) do about this.

The gap is not in the sound itself. The truncated chainsaw sound that I posted above also plays a gap between its end and the chainsaw rumble.

fabiangreffrath commented 8 years ago

I guess it has to do with the duration of the chainsaw states, then. AFAICT, the sawidl sound is played in A_WeaponReady() which in turn is only called every 4 tics. If the full sawup sound is longer than an integer multiple of 4 tics, the remainder (i.e. sound duration % 4 tics) will be silence. Does this make sense?

plumsinus commented 8 years ago

Ah, yeah that does make sense.