search

fabiangreffrath / crispy-doom

Crispy Doom is a limit-removing enhanced-resolution Doom source port based on Chocolate Doom.
https://fabiangreffrath.github.io/crispy-homepage
GNU General Public License v2.0
802 stars 132 forks source link

Resolution-tuned weapon sprite 1 pixel height adjustment for compatibility with bit-shifting hires forks #1189

Closed SoDOOManiac closed 3 months ago

SoDOOManiac commented 7 months ago

Use FRACUNIT/(2<<crispy->hires) instead of FRACUNIT/constant.

Sorry @JNechaevsky, flexible solutions are usually better.

fabiangreffrath commented 3 months ago

Sorry @JNechaevsky, flexible solutions are usually better.

Why "sorry", did @JNechaevsky suggest a different approach?

SoDOOManiac commented 3 months ago

Why "sorry", did @JNechaevsky suggest a different approach?

Yes, the previous fix was if not suggested then at least bugreported by her: https://github.com/fabiangreffrath/crispy-doom/commit/a788f63a69382629545aec7d70717f7487a8d88e

fabiangreffrath commented 3 months ago

I see. And your approach works for normal, double and quad resolution?

SoDOOManiac commented 3 months ago

I see. And your approach works for normal, double and quad resolution?

Yes, quite right :)

JNechaevsky commented 3 months ago

Actually, I can confirm this issue exist, but not happening in Crispy's 1x/2x resolutions. Here's my approach, where vid_resolution is rendering resolution multipler, works fine with all 1x..6x.

But which one is better and fits better for Crispy - honestly, no idea, so I didn't suggest it.