search

fabiangreffrath / crispy-doom

Crispy Doom is a limit-removing enhanced-resolution Doom source port based on Chocolate Doom.
https://fabiangreffrath.github.io/crispy-homepage
GNU General Public License v2.0
806 stars 132 forks source link

Crash when trying to load a non-existent savegame from the command line #267

Closed SoDOOManiac closed 6 years ago

SoDOOManiac commented 6 years ago

When trying to load a non-existent savegame (empty slot) from the command line, the executable crashes. E.g. -loadgame (i) when doomsav(i) file doesn't exist. I think the program should error out by code 'Savegame %ssav%d does not exist', game_name, i where game_name is substituted based on the loaded IWAD: 'doom' for Doom series, 'chex' for Chex/Chex2, 'hacx' for Hacx.

fabiangreffrath commented 6 years ago

Good catch, I wasn't even aware of that! However, this isn't something that should get a fix in Crispy alone. I am sure that properly quitting the game with an error message is applicable to Choco as well. Would you mind raising this issue up there as well, please?

SoDOOManiac commented 6 years ago

Done :) https://github.com/chocolate-doom/chocolate-doom/issues/990

fabiangreffrath commented 6 years ago

Great, thank you!

SoDOOManiac commented 6 years ago

It has been fixed, time to merge ;)

fabiangreffrath commented 6 years ago

Indeed, thanks for taking this upstream!

SoDOOManiac commented 6 years ago

@chungy has finalized the fix the way we suggested ;)