search

fabiangreffrath / crispy-doom

Crispy Doom is a limit-removing enhanced-resolution Doom source port based on Chocolate Doom.
https://fabiangreffrath.github.io/crispy-homepage
GNU General Public License v2.0
810 stars 131 forks source link

35fps during demo playback with menu open, regardless of chosen rendering framerate #307

Closed mfrancis95 closed 6 years ago

mfrancis95 commented 6 years ago

Even if you're set to using uncapped or vsync rendering framerates, demos will play at 35fps whenever the menu is shown.

fabiangreffrath commented 6 years ago

Indeed, this is because of this condition here: https://github.com/fabiangreffrath/crispy-doom/blob/master/src/doom/r_main.c#L983

May I should change !menuactive to !(menuactive && !demoplayback).

mfrancis95 commented 6 years ago

In fe4b698, this wasn't fully fixed. When the menu is shown, the player's sprite is seen "lagging" in front of the view.

fabiangreffrath commented 6 years ago

Sorry, I don't understand. Could please elaborate a bit?

fabiangreffrath commented 6 years ago

Never mind, I think I got it.