fabiangreffrath / crispy-doom

Crispy Doom is a limit-removing enhanced-resolution Doom source port based on Chocolate Doom.
https://fabiangreffrath.github.io/crispy-homepage
GNU General Public License v2.0
802 stars 132 forks source link

Issue in Crispy with SIGIL MIDI and VST players. #498

Closed putridpete closed 4 years ago

putridpete commented 4 years ago

I've been using Falcosoft's MIDI Player to use a Yamaha S-YXG50 VSTi plugin to play MIDIs. I've noticed that in Crispy Doom whenever I play the first level of SIGIL, the MIDI has a part where the volume is really low. You can hear an example in this link: https://streamable.com/vdp9b. The same issue also happens with VSTHost or Savihost. It also happens with any other plugin, such as Sound Canvas VA. The issue is not present in PrBoom+ or GZDoom. Here's how it sounds in PrBoom+: https://streamable.com/07sm9.

This problem seems to happen only in SIGIL, as I've played through all previous four episodes of Doom without any issues. I've yet to play Doom II, however.

I'm using Crispy Doom 5.6.3, Windows 10, and other additional tools that may be related such as OmniMIDI, OmniMapper (also tried CoolSoft's MIDIMapper to no avail) and loopMIDI.

Could the issue be on my end due to a wrong configuration? Regardless, I'd appreciate any help.

fabiangreffrath commented 4 years ago

Sorry, but I will never be able to reproduce this.

putridpete commented 4 years ago

Oh well, since it only happens with SIGIL, I guess I'll just have to fire up PrBoom+ for that. Crispy Doom's sound out of the box won't work for me without the older DLLs Zodomaniac provided (https://www.doomworld.com/forum/post/2035784), so I'm guessing it's related to that in some form. Thanks anyway.

fabiangreffrath commented 4 years ago

Thanks for reporting anyway!

SoDOOManiac commented 4 years ago

@putridpete, I'm glad that the older DLLs resolve your issue :) @fabiangreffrath, are you going to report this issue and that SDL 2.0.10 bugged audio with 5.1 sound configuration on Windows in SDL2 issue tracker?

fabiangreffrath commented 4 years ago

No, because I couldn't answer any questions. That's why "someone told me that this doesn't work" bug reports are mostly/always useless.

SoDOOManiac commented 4 years ago

https://www.youtube.com/watch?v=WBWB81EOVQQ This is the demonstration of the sound bug on Windows with speaker configuration 5.1: no music and high-pitched sound effects. I thought that your word as that of a developer would have more impact than mine :)

fabiangreffrath commented 4 years ago

Nope. They won't care about me developing a Doom source port or not. But they might have questions regarding speaker setup, driver versions etc. that I just won't be able to answer.

putridpete commented 4 years ago

Just for posterity, and if anybody who has the same issue finds this, I at least managed Roland's Sound Canvas VA to work with SaviHost to solve this problem. I simply switched to the x64 version and it worked. I was using the x86 version because the Yamaha VSTi plugin was x86 only and that's the one I downloaded first. However, VSTHost and Falcosoft's MIDI player still present the same issue even on their x64 varieties. Sadly no luck to get the S-YXG50 VSTi plugin to work properly since it's x86 only, so I can't test it with the x64 working version of SaviHost.

Anyway, here's the bittersweet victory of at least getting SCVA to render that part in Crispy Doom and allowing me to avoid a port switcheroo: https://streamable.com/mf0xm

Hope this information proves useful to anyone.

Edit: Played through all of Doom II in Crispy Doom while using Falcosoft's MIDI Player and Sound Canvas VA without any issues whatsoever. I also ultimately ended up playing SIGIL in PrBoom+ after all, because the options that Falcosoft's MIDI player provides are far superior.

putridpete commented 4 years ago

Sorry to keep posting on this after it's been closed, but I've come up with a new development. I found out that while using the Sound Canvas VA plugin with Falcosoft's MIDI player, if I start Crispy with the SIGIL wad and play the Knee Deep in the Dead episode first, then switch over to the SIGIL episode, any issues with the MIDIs get sorted out. You have to do this every time you start SIGIL, even if you've already beaten the opening level because there are a few other MIDIs that present problems later on, such as the ending theme.

For the S-YXG50 VSTi plugin, I have excellent news as well. I also managed to get it to work. What you need to do is hit the reset button that is present in Falcosoft's MIDI player from either the main menu or another episode, then start the SIGIL episode and all MIDIs play fine. As with SCVA, you have to do this everytime you start up SIGIL for the aforementioned reasons. This method DOES NOT WORK with Sound Canvas VA, however. Edit: Actually it does work with SCVA, it just refused to work when I first tried it for whatever reason. This method might be even better for SCVA since the audio levels all match quite well after performing it.

Why this fixes all issues is beyond me, but hey... it works!