search

fabiangreffrath / crispy-doom

Crispy Doom is a limit-removing enhanced-resolution Doom source port based on Chocolate Doom.
https://fabiangreffrath.github.io/crispy-homepage
GNU General Public License v2.0
808 stars 132 forks source link

Option to turn off extra leaving messages (CONTAINING PROFANITY!). #51

Closed Danfun64 closed 10 years ago

Danfun64 commented 10 years ago

While some like this option, I think it would be nice to have the option to turn it off.

fabiangreffrath commented 10 years ago

So, you want an additional switch to turn off the profane variants of that one sentence that is shown to you when you quit the game? Sorry, no way.

plumsinus commented 10 years ago

@Danfun64 one workaround is to hold run and press F10 to quit, that way you'll exit the game instantly. I too am not thrilled about the profane quit messages to be honest -- I don't care about them either way myself, but there are times when I'm playing around other people who I think wouldn't appreciate seeing them, if they were paying attention. So in those cases I use run+F10, which is good enough.

Danfun64 commented 10 years ago

I came up with my own solution. Forking. Unfortunately all I can do is disable the rude messages. If I knew C, I would have added "turn on extra leaving messages" into the "crispiness" part of setup and made it a bullion, but I don't know C, so all I can do is comment out some lines and remove parts of others.

fabiangreffrath commented 10 years ago

Oh, I would have never expected that someone may feel uneasy about these messages. I have added them because there was a demand expressed for them in a recent DW thread.

Since I'd rather remove a feature than add an addtional switch for it, do you think anybody will miss them?

plumsinus commented 10 years ago

Say hello to (North) American morality, where blood and gore is fine but some harsh language is potentially offensive! ;p Honestly I don't really care so much, it comes up rarely enough for me that run+F10 is good enough. But maybe @Danfun64 would appreciate it.

Then again I don't think anyone will miss them too much if they're gone. Another possible option might be to add a command-line parameter to disable (or enable) them but that's still probably one more option too many.

Danfun64 commented 10 years ago

To be fair, I don't care much about the blood and gore either, considering that I have a personal clean-fd project which tones it down (along with hellish imagery).

Name one FLOSS and Free Content family friendly SP/COOP fps. There isn't any. (Before you ask, Chex Quest is non-free content-wise.)

That is why I wanted the rude comments to be optional, as it would conflict with the aim of my sideproject. However, those who like being vulgarly insulted should still be allowed the choice, and since you @fabiangreffrath reenabled them in the first place, it would probably be best for you to make them optional, a compromise between the two choices.

fabiangreffrath commented 10 years ago

There won't ever be another option for this, so I will remove these messages entirely again. They don't win the game anything and their reception is mostly negative, as this report shows. They were disabled for a reason...

Danfun64 commented 10 years ago

I set up a pull request #52 if you want to merge my changes. However if you want to disable the messages a different way that's fine with me.