search

fabiangreffrath / taradino

SDL2 port of Rise of the Triad
GNU General Public License v2.0
35 stars 9 forks source link

make -Wall clean #13

Closed fabiangreffrath closed 1 year ago

malespiaut commented 1 year ago

I would recommend going step-by-step, and also taking into account -Wextra, -Wpedantic, and -Wshadow.

fabiangreffrath commented 1 year ago

I have a PR ready that fixes all -Wall warnings in one. It also adds -Werror to the CI build.

malespiaut commented 1 year ago

I'm currently fixing some missing -Wall errors in the wall branch. I'll do a pull request as well. I don't know yet if my commits fits what you are expecting for your project.

fabiangreffrath commented 1 year ago

I'm currently fixing some missing -Wall errors in the wall branch. I'll do a pull request as well. I don't know yet if my commits fits what you are expecting for your project.

I'm thankful for any contribution, really! Is your patch meant to be applied after my -Wall fixes branch?