search

fabiangreffrath / taradino

SDL2 port of Rise of the Triad
GNU General Public License v2.0
35 stars 9 forks source link

Wipe out unused code #27

Closed malespiaut closed 1 year ago

malespiaut commented 1 year ago

Another bold proposal.

The codebase have its fair share of #ifdef DEBUG, #if 0, and unused code, which only gets in the way of readability. I, for one, would be happy to meticulously remove all of that crust, one file at a time… with permission, of course.

fabiangreffrath commented 1 year ago

Yes, please! That was on my TODO list anyway.

fabiangreffrath commented 1 year ago

DEVELOPMENT is another such macro. Or do you know what it is/was good for?

malespiaut commented 1 year ago

So far it seems that DEVELOPMENT prints a lot of information on the standard output. On that note, I have suspected, while working on ROTT debug code a few years prior, that they had a physical printer printing info when debugging the game. But that's only a supposition.

fabiangreffrath commented 1 year ago

Fixed by https://github.com/fabiangreffrath/rott/commit/69822130def385a0c4e1295986f73dfe22ed0f87 ?

malespiaut commented 1 year ago

It is, yes!

fabiangreffrath commented 1 year ago

Not bad:

$ git diff 20211123 --shortstat
 197 files changed, 1872 insertions(+), 44096 deletions(-)