Although I'm not a suckless zealot, I think that some work should be in that direction. Either refactoring functions to make them smaller (some functions are copies with only a small variation and could be rewriten to be a single function with a switch case), a lot of useless comments could be replaced with usefull comments, or splitting big C files into smaller ones. I think that a “limit” of around 2,000 lines per files (including comments) is not a bad idea.
However, I must precise that this is, in my opinion, a very low priority issue, that should only happen after all functional changes has been made to the code. But it's something to keep in mind to increase code readability, and therefore increase the number of potential contributors, or tinkerers.
I'm sure that anybody who have read Rise of the Triad's source code have noticed that some functions, and therefore C files, are exceptionnaly long.
Right now, the longest file is
rt_actor.c
, with 13,475 lines.Although I'm not a suckless zealot, I think that some work should be in that direction. Either refactoring functions to make them smaller (some functions are copies with only a small variation and could be rewriten to be a single function with a switch case), a lot of useless comments could be replaced with usefull comments, or splitting big C files into smaller ones. I think that a “limit” of around 2,000 lines per files (including comments) is not a bad idea.
However, I must precise that this is, in my opinion, a very low priority issue, that should only happen after all functional changes has been made to the code. But it's something to keep in mind to increase code readability, and therefore increase the number of potential contributors, or tinkerers.