search

fabiangreffrath / woof

Woof! is a continuation of the Boom/MBF bloodline of Doom source ports.
GNU General Public License v2.0
217 stars 37 forks source link

implement Automap color presets #108

Closed OpenRift412 closed 1 year ago

OpenRift412 commented 3 years ago

Just an idea, it would be nice to have the ability to easily swap between different automap color presets without having to manually do them by hand.

Preset ideas:

fabiangreffrath commented 3 years ago

This is indeed a nice idea. Could you probably provide e.g. a chart with the corresponding values for the automap colors?

OpenRift412 commented 3 years ago

Could you probably provide e.g. a chart with the corresponding values for the automap colors?

Well I don't know entirely about ZDoom, Boom/MBF seems to be the current default anyway, but here's my config, which has the vanilla colors matched as best I can. I checked each of the colors in photoshop and they seem to check out.

woof vanilla automap.zip

fabiangreffrath commented 3 years ago

One issue I have with this idea is that there is already a "reset to defaults" button in the automap colors menu. Adding a second switch of that kind would be pretty redundant. And this all clashes with the idea to reset to the Vanilla color scheme. Probably I'll just include it as a config example.

fabiangreffrath commented 3 years ago

Honestly, I don't think we will get any further with this than the config file snippet that we already ship to change the map colors to the Vanilla scheme.

OpenRift412 commented 1 year ago

Hey @fabiangreffrath so I was thinking recently, since @JNechaevsky's International Doom has its own automap palette preset selector, perhaps that could be implemented into Woof? Or would that not be worthwhile?

fabiangreffrath commented 1 year ago

That would have two presets, Vanilla and Boom, right? Or how far does this go? How about map colors that are provided by an OPTIONS lump?

fabiangreffrath commented 1 year ago

If this gets implemented, I'd argue for removing all but the first page of the Automap setup menu and really just keep the explicit choice of "Boom" or "Vanilla" color scheme. The config vars would stil be there and available to OPTIONS lumps, but nothing more should really be required.

rfomin commented 1 year ago

If this gets implemented, I'd argue for removing all but the first page of the Automap setup menu and really just keep the explicit choice of "Boom" or "Vanilla" color scheme.

I agree, but it's interesting to get @OpenRift412's opinion. Personally, I've never used the automap color editor.

fabiangreffrath commented 1 year ago

The config vars would stil be there and available to OPTIONS lumps

Speaking if which, do they actually permanently overwrite the player's choice of automap colors once loaded?

rfomin commented 1 year ago

Speaking if which, do they actually permanently overwrite the player's choice of automap colors once loaded?

Yes. We've even grayed out the menu items in their respective colors.

fabiangreffrath commented 1 year ago

What I mean is, are the values set by the OPTIONS lump saved in the config file and then reloaded for all subsequent plays, even without that specific OPTIONS lump?

fabiangreffrath commented 1 year ago

Hm, I think we need even three settings then, with "Boom" and "Vanilla" having their target colors mapped to the current palette, and "Custom" (or "Default") using the values from the OPTIONS lump / config file.

rfomin commented 1 year ago

What I mean is, are the values set by the OPTIONS lump saved in the config file and then reloaded for all subsequent plays, even without that specific OPTIONS lump?

No, the values from the OPTIONS lump will be applied only for the current game.

fabiangreffrath commented 1 year ago

Oh, wow! I didn't even know. Parts of the config/menu system are still a miracle to me. 😁

So, if it's possible for content creators to temporarily override specific map colors according to their own palette, then we really only need a means to reset colors to either preset.

fabiangreffrath commented 1 year ago

Preset ideas:

[...]

  • ZDoom

Did ZDoom even have a specific automap color scheme?

OpenRift412 commented 1 year ago

Preset ideas: [...]

  • ZDoom

Did ZDoom even have a specific automap color scheme?

It did, it was kind of similar to Heretic where it was mostly shades of brown, something like that. Or maybe that was GZDoom?

OpenRift412 commented 1 year ago

If this gets implemented, I'd argue for removing all but the first page of the Automap setup menu and really just keep the explicit choice of "Boom" or "Vanilla" color scheme.

I agree, but it's interesting to get @OpenRift412's opinion. Personally, I've never used the automap color editor.

Honestly, while I personally wouldn't mind having the color editor removed, I do get the feeling it's removal would generate some complaints. I think the best medium between the two would be to remove the color editor from the settings menu, but still allow customization through the CFG file. But even then, I don't know if that'd be the best course of action. It's really up to you how you'd want to go about it.

fabiangreffrath commented 1 year ago

I think the best medium between the two would be to remove the color editor from the settings menu, but still allow customization through the CFG file.

That's the plan. It would save us two pages of setup submenus, a whole menu item category (S_COLOR), three embedded lumps and a file in docs/.