Bug: Rocket Launcher stays centered when switching from another weapon

[Wavy667]

When Weapon Alignment is set to Centered, the Rocker Launcher sprite on the HUD remains centered when switching from another firing weapon despite the Rocket Launcher not firing itself.

Reproducing

• Set Weapon Alignment is set to Centered
• Hold down fire on any weapon that isn't the Rocket Launcher
• While fire is held down, switch to the Rocket Launcher
• The Rocket Launcher sprite remains centered on the HUD

[fabiangreffrath]

Same in DSDA-Doom. This is because the Rocket Launcher (and the BFG, btw) aren't actually firing when switched to in attacking mode. I don't see much of a problem in this, though.

[Wavy667]

I know the firing lock is intended behaviour, but visually it doesn't match up compared to when Weapon Alignment is set to default because when switching to the Rocket Launcher or BFG, they still sway unlike when Weapon Alignment is set to Centered (which is more natural IMO since they are not actually firing).

[fabiangreffrath]

I think the reason is that we are checking for player->attackdown here instead of player->cmd.buttons & BT_ATTACK and I think there was a reason for this, but I can't remember right now.

https://github.com/fabiangreffrath/woof/blob/a55429f6b8e228030ae2b7557890da78fff2605d/src/p_pspr.c#L1160