fabianishere / boot2flappy

Flappy Bird as bootable UEFI executable
MIT License
62 stars 3 forks source link

README doesn't mention requirement to clone submodule #2

Closed pief closed 4 years ago

pief commented 4 years ago
git submodule init
git submodule update

is needed when cloning the repo, even when building with Docker.

fabianishere commented 4 years ago

Ah, I had not thought about that. Is #3 clear enough?

pief commented 4 years ago

Yes, perfect!

One more thing I just noticed: after building with docker, the build/ directory tree might have the wrong permissions being owned by root. I needed to chown -R in order to run build/vm/start.sh.

Thanks for coding this BTW, and in case you were wondering why for God's sake someone else would use it: I currently use it to debug UEFI booting from the local EFI partition vs. UEFI pxe boot. Unfortunately I can't even get boot2flappy to boot from the local EFI partition on my Dell PowerEdge R740 server here (yes, there are insane people booting EFI games on servers ;): "Not Found (14)". No permissions in place on a FAT filesystem, so it can't be that.

fabianishere commented 4 years ago

@pief Hmm, I don't think we can fix that, given that Docker runs as root user. Though, we can still document it.

Very interesting use-case! :P For my information, does it print the welcome message before the Not Found error (That is, "Welcome to Flappy Bird!")? In that case, it looks like it couldn't find the sprites on the filesystem.

pief commented 4 years ago

Yes, documenting it is enough.

Fixed it: what did not work was creating a directory EFI/boot2flappy and placing BOOTX64.EFI and SPRITES.BMP there. Once I copied both files to EFI/boot (with BOOTX64.EFI renamed to boot2flappy.efi so I don't overwrite my actual bootloader...) it booted like a charm. Thanks again.

fabianishere commented 4 years ago

Great to hear! Does the game actually run on the PowerEdge? I did not always reliably work on real hardware for me.

pief commented 4 years ago

See for yourself -- the next big (as in big iron) gaming platform ;) https://youtu.be/KsYmklvE6aQ

pief commented 4 years ago

One more note: unfortunately it doesn't support PXE booting -- fails at "Obtain root directory of file system" with "WAIT". And no, I do not expect you to implement PXE support ;) Have a great day!

fabianishere commented 4 years ago

Never would have expected it to run on a server :) Have a great day too!