fabianishere / brainfuck

Brainfuck interpreter written in C
Apache License 2.0
528 stars 74 forks source link

Build fails due to editline #67

Closed eeerrrttty closed 4 years ago

eeerrrttty commented 4 years ago

[ 33%] Built target brainfuck [ 50%] Building C object CMakeFiles/brainfuck-cli.dir/src/main.c.o /home/romario/super-ia-project/bfinterpreter2/src/main.c:23:11: fatal error: editline/readline.h: No such file or directory

include <editline/readline.h>

       ^~~~~~~~~~~~~~~~~~~~~

compilation terminated. CMakeFiles/brainfuck-cli.dir/build.make:62: recipe for target 'CMakeFiles/brainfuck-cli.dir/src/main.c.o' failed make[2]: [CMakeFiles/brainfuck-cli.dir/src/main.c.o] Error 1 CMakeFiles/Makefile2:904: recipe for target 'CMakeFiles/brainfuck-cli.dir/all' failed make[1]: [CMakeFiles/brainfuck-cli.dir/all] Error 2 Makefile:140: recipe for target 'all' failed make: *** [all] Error 2

rien333 commented 4 years ago

Well, do you have the appropriate library installed?

eeerrrttty commented 4 years ago

And now?!

fabianishere commented 4 years ago

@eeerrrttty Have you tried to install editline on your machine?

eeerrrttty commented 4 years ago

I'll try

rien333 commented 4 years ago

@eeerrrttty What OS are you on? It's pretty easy to figure out how to install it from that point

eeerrrttty commented 4 years ago

Ubuntu 18. Resolved after editline install

eeerrrttty commented 4 years ago

Put sudo apt-get install libedit-dev as a dependency on readme instructions

rien333 commented 4 years ago

@eeerrrttty from the README:

Brainfuck requires CMake and a C compiler (e.g. Clang or GCC) in order to run. It also depends on libedit, which is available in the main repositories of most Linux distributions (e.g. as libedit-dev on Debian)

The fact that you need to sudo apt-get install libedit-dev is already implied by the fact that the Debian package is named libedit-dev (I suppose you are on Ubuntu, which is more or less a Debian derivative).

That said, it might be nice to have installation instructions for different OSes, or, alternatively, just package this interpreter for distros and list the corresponding links.

fabianishere commented 4 years ago

Fixed in #70.