search

fabianishere / udm-kernel-tools

Tools for bootstrapping custom kernels on the UniFi Dream Machine
GNU General Public License v2.0
330 stars 23 forks source link

Prevent restarting unifi-os from rebooting UDM again #12

Closed TheJulianJES closed 3 years ago

TheJulianJES commented 3 years ago

Currently, a restart of unifi-os seems to reboot the whole system, as soon as it's loaded again. This is expected because of the auto start by udm-kernel-tools. However, this probably should not happen if the custom kernel was already loaded previously. (Maybe add a config option or just always check that the custom kernel is not already loaded before rebooting the whole system with the custom kernel?)

fabianishere commented 3 years ago

That should indeed not be happening. I'll try to address this soon.

fabianishere commented 3 years ago

Hmm, I can't seem to reproduce the issue. As far as I know, it should not reboot if it detects that it is already running a custom kernel.

See the following code: https://github.com/fabianishere/udm-kernel-tools/blob/38744c37bffb88d824d92ea565e492a3a5651b11/udm-bootctl#L223-L234

TheJulianJES commented 3 years ago

Huh, that seems weird. I'm pretty sure my system "double restarts" when doing unifi-os restart. I'm still running the initial version though. I'll try to reproduce it later and also upgrade.

Not sure if that's related, but I enabled the auto restart thing that kexec gives you at installation (wasn't mentioned in the guide and I thought it might be needed for the auto restart to work).

TheJulianJES commented 3 years ago

Just got around to trying this again (with the same original version of udm-kernel/udm-kernel-tools I installed where I remember having this issue previously): It didn't happen again. I only experienced this issue once where I entered unifi-os restart and the whole system rebooted (got the "Starting..." circle thing on the display of the UDMP twice (as expected when doing a full restart with a custom kernel)) and also had routing temporarily "disabled". Since then, I always avoided unifi-os restart.

But as I was also unable to reproduce this issue now, I'll close it. Seems to work as expected. Perhaps it was user error of some sort? (Thanks for trying to debug this!)