fabianlinz / serenity-junit5

JUnit5 integration for Serenity BDD
Apache License 2.0
6 stars 11 forks source link

Upgrade to serenity-core version that supports @Disabled for step methods #6

Closed fabianlinz closed 4 years ago

fabianlinz commented 5 years ago

While working on #3 we noticed that serenity-core includes an implicit dependency to JUnit4, by checking for the name of the JUnit4 annotation "@Ignore" to decide if a step method should be skipped. The analog Junit5 annotation "@Disabled" is not supported at the moment. Once support is added in serenity-core the new version should be used.

net.thucydides.core.annotations.TestAnnotations#isIgnored(java.lang.reflect.Method)

Additional tasks

fabianlinz commented 5 years ago

https://github.com/serenity-bdd/serenity-core/issues/1858

fabianlinz commented 4 years ago

2.0.90 includes support for @Disabled annotation

https://github.com/serenity-bdd/serenity-core/pull/1890 https://github.com/serenity-bdd/serenity-core/releases/tag/v2.0.90