fabianmichael / kirby-typography

Typographic enhancements for your Kirby-driven website.
GNU General Public License v3.0
78 stars 4 forks source link

Error with Smartypants in Kirby 2.5.8 #22

Closed tristantbg closed 6 years ago

tristantbg commented 6 years ago

Declaration of Kirby\Plugins\Typography\Component\Typography::parse($text, $force = false) should be compatible with Kirby\Component\Smartypants::parse($text, $force, Field $field)

Any idea how to fix this ?

Thanks a lot

paulrobertlloyd commented 6 years ago

I’m seeing the same issue. I’m guessing it relates to this change:

Custom Markdown and Smartypants parser components now have access to the Field object #611

rcvd commented 6 years ago

Facing it too. Here is how I fixed it:

Add this in line after use Kirby\Plugins\Typography\Cache;

use Field;

and change

public function parse($text, $force = false) {

to

public function parse($text, $force = false, Field $field = NULL) {

wottpal commented 6 years ago

Same Issue