Bump CIRC, fix CI build, add lifetime annotations

stefanlippuner commented 9 months ago

Changes:

Bump CIRCT to https://github.com/llvm/circt/commit/24d394b (already kind-of old by now :|)
- Most changes were done by @maerhart, I only added a few missing libraries
Switch CI build to ninja. Somehow using makefiles and parallel build seems to cause errors on Ubuntu. The CIRCT build instructions also recommend ninja, so I think this should be ok.
Add missing lifetime annotations for trait objects (resolves issue #251)
Pin Rust toolchain version to v1.66
- Building moore with v1.67 or newer results in stack overflows at runtime (e.g. when running the tests). I think fixing this can be deferred for now.
- Change requirements for SV tests
- Ignore error in common_cells (broken on master and here)
- Add tests that were ignored due to issues that have since been resolved.

CI workflow run: https://github.com/stefanlippuner/moore/actions/runs/6361816938

stefanlippuner commented 9 months ago

@maerhart I picked up https://github.com/fabianschuiki/moore/pull/252/commits/37f9596fb80fcf5fd38968fef57447d8a9082068 from your branch. Are you ok with merging that (with the addition of my fixes in 8fd4ee59)?

maerhart commented 9 months ago

I picked up https://github.com/fabianschuiki/moore/commit/37f9596fb80fcf5fd38968fef57447d8a9082068 from your branch. Are you ok with merging that (with the addition of my fixes in 8fd4ee59)?

Of course, thanks for picking it up!

fabianschuiki commented 9 months ago

Awesome, thanks a lot :tada:! Let me kick off the CI run here as well.

fabianschuiki / moore

Bump CIRC, fix CI build, add lifetime annotations #252