search

fabianstarke / jamming

0 stars 1 forks source link

Search function #1

Open thecodeduchess opened 6 years ago

thecodeduchess commented 6 years ago

Hey Fabian, can you check your live demo again?

Spotify seems to be connected properly. The search button works. It quickly refreshes but comes up blank in the results column.

screen shot 2017-12-08 at 12 12 56 pm
fabianstarke commented 6 years ago

Hi,

Thanks for reviewing ! This is an issue i was aware of and I really don't know where this is coming from. It is probably due to a method somewhere but do not know where. Can you help me on that ?

Thanks in advance, Fabian

Best regards Fabian Starke

http://goog_408153243 [image: https://ch.linkedin.com/pub/fabian-starke/16/18b/539] https://ch.linkedin.com/pub/fabian-starke/16/18b/539

2017-12-08 19:16 GMT+01:00 cyr3ne notifications@github.com:

Hey Fabien, can you check your live demo again?

Spotify seems to be connected properly. The search button works. It quickly refreshes but comes up blank in the results column.

[image: screen shot 2017-12-08 at 12 12 56 pm] https://user-images.githubusercontent.com/8722966/33779208-9363ce7c-dc11-11e7-9225-0a1e347c8738.png

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/fabianstarke/jamming/issues/1, or mute the thread https://github.com/notifications/unsubscribe-auth/AIZq0-KMKE9uz60j0eMHB0HwL0P-4UuJks5s-Xz9gaJpZM4Q7dfb .

thecodeduchess commented 6 years ago

Was it also like that on local host ? Before adding your personal link.

fabianstarke commented 6 years ago

yes i had this from the beginning in fact

thecodeduchess commented 6 years ago

You didn't work with an advisor at all?

fabianstarke commented 6 years ago

no, just asked one question

thecodeduchess commented 6 years ago

Ok. It would be best to chat with a live advisor. Debugging projects can take hours. We don't have much time allotted for project review. We have 30 minutes to 1 hour maximum. What I check for is whether the code follows convention, if the styling closely matches to the sample, and if you got most of the features working. Which in this case you did. Even if you continue to work on it, we don't review it again unless it was completely broken and you got a "needs improvement" grade.

You may be better starting from scratch or working on a different project with React (plenty of tutorials online)

You will still get your completion certificate for attempting all of the curriculum.

fabianstarke commented 6 years ago

ok i see no problem, i will check with an advisor than. Thanks