search

fabianvf / python-rake

MIT License
130 stars 35 forks source link

Parameters for configuring word length, phrase length, vector weight. #11

Closed celestelynpaul closed 7 years ago

celestelynpaul commented 7 years ago

It would be nice if this version supported some of the parameters like the Zelandiya implementation.

paladini commented 7 years ago

+1

jkterry1 commented 7 years ago

List the parameters you want and what they do and I'll see what I can do

fabianvf commented 7 years ago

Think changes are addressed in this PR: https://github.com/fabianvf/python-rake/pull/9

jkterry1 commented 7 years ago

@fabianvf is this fixed?

jkterry1 commented 7 years ago

If it is we need to put it in the readme

fabianvf commented 7 years ago

@justinkterry it is not, I have some changes in a PR here: https://github.com/fabianvf/python-rake/pull/16

But wanted to get your thoughts on it before merging in case it breaks you.

jkterry1 commented 7 years ago

I'm half way through a pull request for all the other things I was talking about, let's get that happy and merged and then come back to that.

Also would we be better off using pickle under the hood for the word list functions instead of having it return lists like it does now?

On Tue, Aug 1, 2017 at 3:47 PM, Fabian von Feilitzsch < notifications@github.com> wrote:

@justinkterry https://github.com/justinkterry it is not, I have some changes in a PR here: #16 https://github.com/fabianvf/python-rake/pull/16

But wanted to get your thoughts on it before merging in case it breaks you.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/fabianvf/python-rake/issues/11#issuecomment-319476549, or mute the thread https://github.com/notifications/unsubscribe-auth/AShd7Fss8FM4_IRSbvZP2iNW5h7cRsa7ks5sT4DKgaJpZM4NUalp .

-- Thank you for your time, Justin Terry

jkterry1 commented 7 years ago

@fabianvf didn't my last giant PR close this?

fabianvf commented 7 years ago

yep