search

fabianvf / python-rake

MIT License
130 stars 35 forks source link

fix PR #27 #29

Closed jkterry1 closed 6 years ago

jkterry1 commented 7 years ago

Resolves PR #27. The code should work the way the documentation says because it's easier for people working with it.

jkterry1 commented 7 years ago

@fabianvf please do whatever basic checks you want to and merge this

jkterry1 commented 7 years ago

@fabianvf and push this to PyPI because this is an actual problem

fabianvf commented 7 years ago

@justinkterry not sure I follow this change, it looks like you can no longer set regex, minCharacters, maxWords, or minFrequency?

fabianvf commented 7 years ago

@justinkterry think you need to move those defaults up to the definition of the text function.

jkterry1 commented 7 years ago

@fabianvf the issue you should be able to control the regex, minCharacters, maxWords, or minFrequency when doing each run, not the class instantiation (they aren't used there and it's a pain). This is how the documentation describes it as well. The documentation already agrees with this, hence the problem. You can read more in PR #27 (someone noticed this and thought the documentation should be changed instead). Does that answer your questions?

jkterry1 commented 7 years ago

fixed, thanks for catching that

jkterry1 commented 7 years ago

Done, thanks for catching that. I know for a fact I made that change originally, but apparently it went to a different fork or something...?