fabianwennink / IconCaptcha-ASP.NET

IconCaptcha is a fast, simple and user-friendly captcha. - ASP.NET MVC package
MIT License
15 stars 3 forks source link

Upgrade project to AspNet core 6 #3

Closed PhenX closed 1 year ago

PhenX commented 1 year ago

Hello, I ported the full project from the PHP project, to aspnet core 6.

I'm making this pull request to let you know I'm workign on it, hoping it may be merged one day :)

I need to make a few adjustments though, I let you know when I'm done.

PhenX commented 1 year ago

Hello, I think I'm mostly done. I know the project is marked as obsolete, but I thought that maybe this full rewrite would give it a new start. What do yout think ?

fabianwennink commented 1 year ago

Hi @PhenX! A little update since my reply to your email last week. I haven't had the time yet to properly check out your upgrade to v3 for numerous reasons. I'm currently setting up my workspace again, but as it's been quite a few years since I've touched .NET/C# (I don't work with it professionally), it will take me some time to get the hang of everything again. Once I've got everything set up and refreshed my C# skills, I'll properly review your pull request.

PhenX commented 1 year ago

Thanks for the news ! 😉

fabianwennink commented 1 year ago

Hi @PhenX! I've had the time to test out your pull request, and as far as I can see, everything appears to work properly. I'll merge your pull request to a separate branch soon so that I can make some additional changes, as well as update the README, demos, code comments/docs, and wiki. After that is all done, I'll merge that branch to master and release a new version on NuGet (once I've figured out again how all that works 😶).

PhenX commented 1 year ago

@fabianwennink great news ! But beware, aspnet core is such a good piece of software that you may never want to work on anything else after that ;)

PhenX commented 1 year ago

Hello @fabianwennink any news on this :) ? How can I help you ?

fabianwennink commented 1 year ago

Hi! I sadly haven't had a lot of time to work on this recently. As I commented on a ticket of the PHP project, I work on IconCaptcha after work when I have the time for it. I have made some minor changes, but haven't made a commit for this yet. Currently, getting the new major release of the PHP project ready has a higher priority, as this has been in the works since last year. This is nearing completion, and once that is done, I'll have more time to work on the ASP.NET version.

For now, if you are not already, you can probably just use the source code directly in your project so that you can still use v3. I'll try my best to get v3 on NuGet ASAP, but like I said, my time to work on the project is currently limited.

fabianwennink commented 1 year ago

Hi @PhenX! Another quick update. I posted an update about the current state of the upcoming IconCaptcha 4 PHP release. Basically, the development of that version is pretty much done and only updating the wiki documentation is left. The release is scheduled for early to mid-October. When all that is done, I'll shift my focus to the ASP.NET version and make sure to release it ASAP.

PhenX commented 11 months ago

Hello @fabianwennink, I see you released a new version for the PHP version, how can I help to release the one for AspNetCore ?

fabianwennink commented 11 months ago

Hi @PhenX! Yes, IconCaptcha 4 for PHP has finally been released. As I said in my previous comment, once that version was ready, I would continue with the ASP.NET implementation. This will mainly include further adjusting and testing the branch made from your pull request to release it as version 3. I will start with this the upcoming weekend, and expect the version to be ready not that long after.

Version 4 did introduce some new features, but the main focus was refactoring the code to make it available for Composer installation and improve maintainability. The features added in this version (such as database support) will be added at a later time.

fabianwennink commented 11 months ago

Hi! Quick update. I made the first changes to the v3 branch today, updating the code to work with the v3.1.3 assets. After debugging a mistake I made in the process for more than an hour (😢) it appears to work properly now. During the next few days, I'll refactor the code further, update the readme and code docs. I'll most likely release a new version next weekend.

fabianwennink commented 9 months ago

Hi! I just merged the 3.x-develop branch with master. After uploading the package to nuget, I noticed that the formatting used in the README is not supported (oops), so I unlisted the version there for now and contacted Microsoft to get it resolved. Once this is fixed, I will unlist the version and 3.0.0 is available on nuget!

If for some reason it can't be resolved, I will just push a new version to nuget.

PhenX commented 9 months ago

Thank you very much!

PhenX commented 9 months ago

@fabianwennink as of HTML support I doubt it will be supported anytime soon : https://github.com/NuGet/NuGetGallery/issues/8644 In order to have to maintain only a single README file, maybe you could simplify it to use only supported Markdown ? https://learn.microsoft.com/en-us/nuget/nuget-org/package-readme-on-nuget-org#supported-markdown-features

fabianwennink commented 9 months ago

@PhenX Yeah, the README in the IconCaptcha project folder now only uses Markdown. Whether I'm keeping 2 separate files or just use 1, I'll decide at a later point. I kind of like the 'centered' logo 😅.

Also, I changed version 3.0.0 on NuGet back to listed, so the version is available for installation. As somehow there have already been downloads while it was unlisted, it won't be removed by Microsoft anymore anyways. In a next update, the NuGet readme will be corrected. For now, ugly unparsed HTML it is haha. Still think it's weird how, even though GitHub and NuGet are both owned by Microsoft, HTML is only supported on GitHub...

PhenX commented 9 months ago

Yeah I agree about the difference between Nuget and Github. I'm thinking about something for v3.0.1 though : support for net 8 and maybe 7. No complex changes may be needed but at least it will be usable by more people.

fabianwennink commented 9 months ago

Ah, yes that's a good idea. I just tested this, and everything still seems still seems to work on both .NET 7 and .NET 8. I'll test this further tomorrow and release a minor update if everything works correctly.