search

fabien-d / alertify.js

JavaScript Alert/Notification System
http://fabien-d.github.com/alertify.js/
4.26k stars 725 forks source link

Any way to make it working in (IE9) "Compatibility" mode? #126

Closed vkelman closed 11 years ago

vkelman commented 11 years ago

I downloaded a stable version and tried 

 alertify.set({ labels: {ok: "Accept", cancel : "Deny"} });
 alertify.confirm("Confirm dialog with custom button labels", function (e) {
 if (e) { alertify.success("You've clicked OK"); }
 else { alertify.error("You've clicked Cancel"); }

In IE9 in compatibility mode a dialog displays only the left button, until you hover a mouse over the place right button is supposed to be. In IE standard mode it works fine (and works fine in Chrome.)

fabien-d commented 11 years ago

I'll have investigate this one. I'm currently away at a conference but will take a look when I get back.

Any reason why you're running compatibility mode? Just curious!

vkelman commented 11 years ago

Pretty stupid reason: we have a big "legacy" web site which was designed for earlier versions of IE and doesn't want to work correctly in a standard mode of modern IE. Yes, we should update it, but we don't have enough resources.

Vladimir Kelman http://www.google.com/profiles/vkelman

On Wed, Feb 27, 2013 at 4:59 PM, Fabien Doiron notifications@github.comwrote:

I'll have investigate this one. I'm currently away at a conference but will take a look when I get back.

Any reason why you're running compatibility mode? Just curious!

— Reply to this email directly or view it on GitHubhttps://github.com/fabien-d/alertify.js/issues/126#issuecomment-14202923 .

fabien-d commented 11 years ago

I got to test it and was able to recreate the issue.

Compatibility

It's something to do with the :focus state. If you hit the tab key to cycle through the button, whichever one has focus doesn't show. First thing you could try is to remove the :focus state in the CSS. See if that works.

I'll will look at it this weekend, just don't have time while at the conference to debug.

Cheers,

fabien-d commented 11 years ago

I just tested the 0.4.0 release candidate version - tag 0.4.0rc1 and it works. I'll sort out what the differences are between the 2 and get a fix in for the 0.3.* stable release. 0.3.* will be deprecated shortly as 0.4.0 approaches.

Compatibility0 4 0rc1

vkelman commented 11 years ago

Fabien,

Thank you, I really appreciate your responsiveness. Forgive my ignorance, I'm not familiar enough with GitHub, but can I simply download ver. 0.4.0 or should I somehow Clone etc. ?

Vladimir Kelman http://www.google.com/profiles/vkelman

On Thu, Feb 28, 2013 at 1:25 PM, Fabien Doiron notifications@github.comwrote:

I just tested the 0.4.0 release candidate version - tag 0.4.0rc1 and it works. I'll sort out what the differences are between the 2 and get a fix in for the 0.3.* stable release. 0.3.* will be deprecated shortly as 0.4.0 approaches.

[image: Compatibility0 4 0rc1]https://f.cloud.github.com/assets/747616/206580/0e9483cc-81d4-11e2-8f23-3c1e3db7f250.png

— Reply to this email directly or view it on GitHubhttps://github.com/fabien-d/alertify.js/issues/126#issuecomment-14248502 .

fabien-d commented 11 years ago

You can grab the source on the tags page.

Just a word of warning, 0.4.0rc1 is a release candidate, so everything may not be stable, and also the API has changed quite a bit from 0.3.*.

Feel free to look at the demo site at http://fabien-d.github.com/alertify.js/0.4.0rc1

fabien-d commented 11 years ago

Fixed with ^ PR

diviti commented 11 years ago

Hi. Had a similar problem on 0.3.10. Also legacy code ... ;) Alertify bar was positioned on the left side, buttons not visible. <!doctype html> was missing before tag. Including it in doc resolved problem ...