fabien0102 / gatsby-starter

Gatsby 2.0 starter with typescript and many cools dev tools
386 stars 99 forks source link

Fix to connect, add disquss and fix tags card #53

Closed sielay closed 6 years ago

sielay commented 6 years ago
sielay commented 6 years ago

The issue can be solved by change in tsconfig but I want to drill it down as it repeats for everyone and basically blocks build task.

fabien0102 commented 6 years ago

Deploy preview for fabien0102-gatsby-starter ready!

Built with commit 6518dc02798665f1c52603f005d144a3ed4fb1d7

https://deploy-preview-53--fabien0102-gatsby-starter.netlify.com

sielay commented 6 years ago

Will rebase it in the evening

fabien0102 commented 6 years ago

@sielay You can merge this PR after your rebase if everything is green 😉 You are now a collaborator of this project 🎉

sielay commented 6 years ago

@fabien0102 any reason you prefer merge over squash & merge?

fabien0102 commented 6 years ago

@sielay I just like to have a real history :wink: It's better for debugging, understand the context, git bisect, …

sielay commented 6 years ago

Ok. @fabien0102 That's the only reason I did not merge. In my projects, I like to have a simple chart as it's easier to read. I don't see a difference between those two: And seeing people experimenting while patching just distracts me ;)

Mege                           Sqash and merge

 |                                      |
 M                                      C'
 |\                                     |
 |  \                                   |
 |   C                                  |   C
 |   |                                  |   |
 |   C                                  |   C
 |  /                                   |  /
 |/                                     |/ 
 P                                      P
fabien0102 commented 6 years ago

@sielay I don't really see a difference between those two ^^ The merge is the default one, I have my history and it make the job :wink: The only thing that I asked to git, is to have an extra layer of history for hard debugging (sometime really useful!) after if the graph is not "pretty"… Really don't care ^^ But thanks to asked the question, I should maybe add a CONTRIBUTING.md with this kind of topic 😃