search

fabien0102 / gatsby-starter

Gatsby 2.0 starter with typescript and many cools dev tools
386 stars 99 forks source link

Storybook fails on clean install #66

Closed ccjjmartin closed 4 years ago

ccjjmartin commented 6 years ago

Steps to reproduce:

    • gatsby new project https://github.com/fabien0102/gatsby-starter/
    • cd project
    • Make sure you don't have anything running on port 9001
    • yarn run storybook

Get this error:

ERROR in /Users/developer/gatsby/project/node_modules/@types/react-router/index.d.ts (110,50): error TS2304: Cannot find name 'Exclude'.

Found the fix in this open PR:

https://github.com/fabien0102/gatsby-starter/pull/64/files#diff-b9cfc7f2cdf78a7f4b91a753d10865a2R66

Fix:

Upgrade typescript package (in package.json) to 2.8.3 fixed it for me.

sielay commented 6 years ago

Thanks for this one! It's missing bit to this https://github.com/fabien0102/gatsby-starter/pull/64

mattdell commented 6 years ago

@ccjjmartin I've been trying to resolve this for ages before updating my TypeScript version. Cannot believe it was as simple to resolve as just updating TypeScript.

THANK YOU