search

fabien0102 / gatsby-starter

Gatsby 2.0 starter with typescript and many cools dev tools
386 stars 99 forks source link

Migration to Gatsby v2 #73

Closed mrcne closed 6 years ago

mrcne commented 6 years ago

Migrated to Gatsby V2, basing on this guide: https://next.gatsbyjs.org/docs/migrating-from-v1-to-v2/

Related issue: #72

fabien0102 commented 6 years ago

Seams to have some typings error on netlify build, @mpoiu do you have access to the netlify logs?

Note: I know that netlify is a bit sensible on this project, so I will try this locally also :wink:

mrcne commented 6 years ago

Thanks @fabien0102. I have committed coding style fixes and will take a look at netlify build later today or tomorrow.

fabien0102 commented 6 years ago

Deploy preview for fabien0102-gatsby-starter ready!

Built with commit 774f5a61098fc8a64de4d959d03177f5d3aabe36

https://deploy-preview-73--fabien0102-gatsby-starter.netlify.com

fabien0102 commented 6 years ago

@mpoiu Fisrt of all, great job, netlify works! :tada:

I just found some bugs in the preview:

  1. the tag filter is not working any more (all articles are displayed even with an active filter) image

  2. when I click on another article link inside an article, the page in blank image

  3. and a little on for finish, it's not really a bug but you should update Powered with ❤ by Gatsby 1.0 with Powered with ❤ by Gatsby 2.0 (the footer)

mrcne commented 6 years ago

@fabien0102 Thank you for testing it. I have committed fixes to issue 1, 2 and 3. Also added some other small fixes. I will check how it looks with HOC shortly.