fabien0102 / gatsby-starter

Gatsby 2.0 starter with typescript and many cools dev tools
386 stars 99 forks source link

Housekeeping - updates & fixes #96

Closed jamestharpe closed 4 years ago

jamestharpe commented 4 years ago
jamestharpe commented 4 years ago

Hi @fabien0102 - just wanted to say THANK YOU for putting this starter together, I really like it!

I had some trouble getting up-and-running, but everything is now looking good and this pull request resolves all the issues I had. I hope you find it useful!

jamestharpe commented 4 years ago

Not sure why deploy/netlify failed - the log shows no errors. Maybe it timed out? LMK if I can troubleshoot somehow.

fabien0102 commented 4 years ago

Let's try to retry the build, no obvious errors indeed (at least from now ^^)

fabien0102 commented 4 years ago

image

Some unused variables 😬 Normally the logs are public, @jamestharpe tell me if not so I will paste the beast here ^^

(sorry by advance if I'm not very reactive, it's totally the rush at my job 😅)

jamestharpe commented 4 years ago

I fixed what I could glean from the logs, but it's failing w/ out error again :-\

Can you tell me what command is failing and I'll take care of it locally?

fabien0102 commented 4 years ago

Let's try to re-build… 😕

fabien0102 commented 4 years ago

ok… I will try to build locally to see

fabien0102 commented 4 years ago

of course, everything works locally… 🤔

fabien0102 commented 4 years ago

Let's retry with npm instead of yarn, maybe, I hate when netlify crash like this!

fabien0102 commented 4 years ago

image

YES! I may have something, try to run yarn storybook:build, it's failing locally and netlify also built it

jamestharpe commented 4 years ago

Ah, okay - hadn't tested that command! I don't know much about storybook, but I'll see what I can do.

jamestharpe commented 4 years ago

I think I fixed it after going down a bit of a rabbit hole (we'll see when the build finishes!). storybook wasn't compatible with version of TypeScript that was being installed, so I updated TypeScript which required storybook to be recompiled. I ended up needing to run npm install -g --production windows-build-tools then npn rebuild to recompile storybook, at which point the npm run storybook:build succeeded.

fabien0102 commented 4 years ago

Deploy preview for fabien0102-gatsby-starter ready!

Built with commit 9752661fa4115da9221f0c6e4493338bc9c872fb

https://deploy-preview-96--fabien0102-gatsby-starter.netlify.com

jamestharpe commented 4 years ago

Found an issue when serving the storybook - next push will contain the fix.

jamestharpe commented 4 years ago

Anything else I can do for this PR?

fabien0102 commented 4 years ago

Looks good!