Closed jamestharpe closed 4 years ago
Hi @fabien0102 - just wanted to say THANK YOU for putting this starter together, I really like it!
I had some trouble getting up-and-running, but everything is now looking good and this pull request resolves all the issues I had. I hope you find it useful!
Not sure why deploy/netlify
failed - the log shows no errors. Maybe it timed out? LMK if I can troubleshoot somehow.
Let's try to retry the build, no obvious errors indeed (at least from now ^^)
Some unused variables 😬 Normally the logs are public, @jamestharpe tell me if not so I will paste the beast here ^^
(sorry by advance if I'm not very reactive, it's totally the rush at my job 😅)
I fixed what I could glean from the logs, but it's failing w/ out error again :-\
Can you tell me what command is failing and I'll take care of it locally?
Let's try to re-build… 😕
ok… I will try to build locally to see
of course, everything works locally… 🤔
Let's retry with npm instead of yarn, maybe, I hate when netlify crash like this!
YES! I may have something, try to run yarn storybook:build
, it's failing locally and netlify also built it
Ah, okay - hadn't tested that command! I don't know much about storybook, but I'll see what I can do.
I think I fixed it after going down a bit of a rabbit hole (we'll see when the build finishes!). storybook
wasn't compatible with version of TypeScript that was being installed, so I updated TypeScript which required storybook
to be recompiled. I ended up needing to run npm install -g --production windows-build-tools
then npn rebuild
to recompile storybook
, at which point the npm run storybook:build
succeeded.
Deploy preview for fabien0102-gatsby-starter ready!
Built with commit 9752661fa4115da9221f0c6e4493338bc9c872fb
https://deploy-preview-96--fabien0102-gatsby-starter.netlify.com
Found an issue when serving the storybook - next push will contain the fix.
Anything else I can do for this PR?
Looks good!