search

fabienjuif / gitmoji-changelog-rust

Do you use gitmoji? Then generate your changelog with this app!
https://docs.rs/gitmoji-changelog/
MIT License
12 stars 1 forks source link

missing git tags when there's some #17

Open Roms1383 opened 1 year ago

Roms1383 commented 1 year ago

Hi there ! I just literally tried out your tool and got this error (NoTag) while I do actually have tags in my repo, e.g. : v0.2.2. My first assumption is that the format of my tags does not match with gitmoji-changelog-rust's expectations, or am I missing something ?

fabienjuif commented 1 year ago

Hello 👋 ,

Maybe this commit introduced the bug: https://github.com/fabienjuif/gitmoji-changelog-rust/commit/62c0b884bec2a3109096b151f7e041bf9583f38e

  1. Can you try to use the v0.3.0?
    • cargo install gitmoji-changelog@0.3.0
  2. If you want to stick with the v0.4.0, can you try to set the -r option with the current tag? The previous?
  3. Remember this rust version is a playground and a fork of: https://github.com/frinyvonnick/gitmoji-changelog if you want to give it a try!

Thank you for your interest

Roms1383 commented 1 year ago

Maybe this commit introduced the bug: https://github.com/fabienjuif/gitmoji-changelog-rust/commit/62c0b884bec2a3109096b151f7e041bf9583f38e

  1. Can you try to use the v0.3.0? cargo install gitmoji-changelog@0.3.0

I just gave a try and indeed changelog shows up in the terminal !

If you want to stick with the v0.4.0, can you try to set the -r option with the current tag? The previous?

What is the -r option ?

fabienjuif commented 1 year ago

gitmoji-changelog --help

    -r, --release <release>    Set a version to the release (latest tag to HEAD). 
                               If not set, the commits after the latest tag will not be printed to the changelog.

I'll try to look at the the commit that introduced the bug (or revert it). If you want to give it a look and fix it, go ahead!

Meanwhile, is it ok to use the 0.3.0 for you?

Roms1383 commented 1 year ago

no worries, it's perfectly ok to use 0.3.0! :) if I get some spare time I'll try to look into it but can't promise.

Roms1383 commented 1 year ago

by the way mere guess here, but looking at the commit you pointed out it could come from these changes since it only checks the first entry of versions which I assume might contain many versions.

fabienjuif commented 1 year ago

Yep but then the NoTag error becomes useless.