search

fabienrenaud / java-json-benchmark

Performance testing of serialization and deserialization of Java JSON libraries
MIT License
971 stars 134 forks source link

Remove Jsoniter #66

Closed SentryMan closed 1 year ago

SentryMan commented 1 year ago

I guess it's not working on JDK 17.

fabienrenaud commented 1 year ago

Flagged the issue on the java jsoniter project: https://github.com/json-iterator/java/issues/341

plokhotnyuk commented 1 year ago

@fabienrenaud @SentryMan How about using jsoniter-scala?

Would you let the beast of Scala beat all the Java kittens?

SentryMan commented 1 year ago

You could probably raise a pr to add if you want.

Would you let the beast of Scala beat all the Java kittens?

Oho? I'd like to see you try at least.

fabienrenaud commented 1 year ago

@plokhotnyuk I don't mind as long as it integrates well into the project (I don't see how since everything is written in Java). Feel free to send a PR though.

plokhotnyuk commented 1 year ago

@plokhotnyuk I don't mind as long as it integrates well into the project (I don't see how since everything is written in Java). Feel free to send a PR though.

Yep, before doing that I would refactor your benchmark to be simpler, correct, and more reusable.

Please see how benchmarks are implemented to test different JSON parsers for Scala on different platforms here.

fabienrenaud commented 1 year ago

before doing that I would refactor your benchmark to be simpler, correct, and more reusable.

@plokhotnyuk Sounds great! What do you find to be not correct with this benchmark?

plokhotnyuk commented 1 year ago

before doing that I would refactor your benchmark to be simpler, correct, and more reusable.

@plokhotnyuk Sounds great! What do you find to be not correct with this benchmark?

I think we should follow the best JMH practices, avoid measuring redundant virtual calls, null and instanceof checks.