search

fabienrenaud / java-json-benchmark

Performance testing of serialization and deserialization of Java JSON libraries
MIT License
980 stars 135 forks source link

update json library versions #71

Closed SentryMan closed 1 year ago

SentryMan commented 1 year ago

fastjson breaks with that version

 java.lang.reflect.InaccessibleObjectException: Unable to make private java.time.OffsetDateTime(java.time.LocalDateTime,java.time.ZoneOffset) accessible: 
module java.base does not "opens 
java.time" to unnamed module @37ceb1df`

EDIT: figured out how to do -add-opens with gradle, but now test assertions are failing EDIT2: looks like it's not serializing dates correctly

SentryMan commented 1 year ago

also yasson uses jakarta instead of javax now, so will have to untangle that mess

SentryMan commented 1 year ago

I can't upgrade yasson because apache johnzon is using javax JSONP.

SentryMan commented 1 year ago

other than yasson that's all of them

SentryMan commented 1 year ago

@rmannibucau, I see you are involved with johnzon, do you know when/if they will use jakarta JSON-P?

rmannibucau commented 1 year ago

@SentryMan not sure what you mean, johnzon implements and uses JSON-P in its mapper and JSON-B implementations since day one and provides a jakarta flavor since a few versions (but can need to play with classifier until next release - try io.yupiik.uship:backbone-johnzon:1.0.16:pom as a presetup pom).

SentryMan commented 1 year ago

but can need to play with classifier until next release

you really do learn something new every day, I never encountered maven classifiers until now.

In any case, we're good now

fabienrenaud commented 1 year ago

I ran and published new benchmark results today. Thanks again @SentryMan This contribution and the others you did definitely helped me fast-tracking running it.