search

fabiensanglard / chocolate_duke3D

chocolate Duke Nukem,3D
598 stars 91 forks source link

Poor quality dock icon (OS X, Win, etc) #8

Open andypiper opened 11 years ago

andypiper commented 11 years ago

Although the duke_3d_icon.icns image is used for the app bundle, when running it appears in the Dock with a lower quality icon. This is caused by the SDL app setting SDL_WM_SetIcon(image,NULL); in display.c

Is this intended in respect of "reproducing the original", or should this call be avoided on OS X so the Info.plist overrides it for modern displays?

fabiensanglard commented 11 years ago

This is an inheritance from xDuke: On Windows 95 platforms this was an improvement from the original icon. We should probably use the MacOS X high quality icon and create Windows Vista/7 icons.

andypiper commented 11 years ago

Fixed the OS X icon although for Retina displays we should build a full iconset https://developer.apple.com/library/mac/#documentation/GraphicsAnimation/Conceptual/HighResolutionOSX/Optimizing/Optimizing.html including images up to 512x512@2x

Windows and Linux currently still call SDL_WM_SetIcon in display.c