search

fabiensanglard / cpsb

The book of CPS-1
MIT License
110 stars 34 forks source link

Fix m68k bus width #151

Closed ltrzesniewski closed 1 year ago

ltrzesniewski commented 1 year ago

The m68k has 16 pins for data and 24 pins for the address.

Joyeux Noël ! 🙂

fabiensanglard commented 1 year ago

Please fix conflict

ltrzesniewski commented 1 year ago

Looks like the same fix was provided in #154, except that PR makes the m68k pins start at A1 instead of A0. I believe A0 is correct in this context, even if the CPS-1 doesn't use it.

fabiensanglard commented 1 year ago

I double checked the pin-outs and they are labelled A1, not A0.

ltrzesniewski commented 1 year ago

Oops, you're right. Looks like there are variants with 20-bit, 22-bit, 23-bit and 24-bit address buses according to the datasheet. 😬

Sorry about the mistake.