search

fabiobiondi / angular-fullscreen

AngularJS HTML5 Fullscreen
214 stars 107 forks source link

bower.json should list dependencies #17

Closed ghost closed 10 years ago

ghost commented 10 years ago

angularjs is in bower, it would be nice if bower.json listed it as a dependency so that we could know which versions of angularjs this is compatible with

fabiobiondi commented 10 years ago

Hi oMouse. I have added the following dependency to bower.json:

"dependencies": { "angular": "~1.2.1" },

Is it enough? Thanks

ghost commented 10 years ago

Yeah I think so. I'm not sure which version of angularjs is the latest anymore haha. On Apr 7, 2014 11:02 AM, "fabiobiondi" notifications@github.com wrote:

Hi oMouse. I have added the following dependency to bower.json:

"dependencies": { "angular": "~1.2.1" },

Is it enough? Thanks

— Reply to this email directly or view it on GitHubhttps://github.com/fabiobiondi/angular-fullscreen/issues/17#issuecomment-39741352 .

fabiobiondi commented 10 years ago

ahaha 1.3.something :P They go too fast!!!! : ) Anyway I have added the dependency to 1.2.1 because we're sure angular-fullscreen works on it.