fabiobiondi / angular-fullscreen

AngularJS HTML5 Fullscreen
214 stars 107 forks source link

missplaced if #19

Closed CosticaPuntaru closed 10 years ago

CosticaPuntaru commented 10 years ago

the if at line 79 if ($attrs.onlyWatchedProperty !== undefined) {

should be placed before the $element.on('click') or better removed at all, using: <div fullscreen> ... </div> will make it full screen on click. and using: <div fullscreen="somevalue"> ... </div> will remove the on click functionality and will only watch on the "somevalue"

if you want both functionalitys you cand write it like this: <div fullscreen="somevalue" ng-click="somevalue = true"> ... </div>