search

fabiobiondi / angular-fullscreen

AngularJS HTML5 Fullscreen
214 stars 107 forks source link

Portability #43

Open gil0mendes opened 9 years ago

gil0mendes commented 9 years ago

Hello, You should change this line:

define("FBAngular", ['angular'], function (angular) { return createModule(angular); } );

to:

define(['angular'], function (angular) { return createModule(angular); } );

To improve the portability of the module ;)

Deklin commented 7 years ago

I opened a PR to fix this.

Deklin commented 7 years ago

https://github.com/fabiobiondi/angular-fullscreen/pull/55

gil0mendes commented 7 years ago

I don't use Angular anymore, but this can be helpful for other people 👍