Context issue in the function all()

fabiobiondi / angular-fullscreen

AngularJS HTML5 Fullscreen

213 stars 107 forks source link

Context issue in the function all() #5

Closed GabrielDelepine closed 10 years ago

GabrielDelepine commented 10 years ago

When the function is called in the scope, "this" is an element of the scope. It's a context issue.

Defined "serviceInstance" solve it.

GabrielDelepine commented 10 years ago

Hi @fabiobiondi,

Did you check my PR ? It's a very small modification but it's necessary to call the functions from the scope.

fabiobiondi commented 10 years ago

Hi @Yappli, sorry for the delay and thanx a lot for your PR. Next week I will fix everything. Promised!

Are you on G+ or skype? I would like to ask you a pvt stuff

GabrielDelepine commented 10 years ago

@fabiobiondi No sorry I don't use G+ or skype. Contact me per email (cf my profile).

GabrielDelepine commented 10 years ago

Hi @fabiobiondi. What did you wanted to ask me ? Unfortunately I dont have enough time to be hire, I just contribut to projects I need for my own website.

fabiobiondi commented 10 years ago

2 months of delay but now I merged your pull request. Thanks a lot

GabrielDelepine commented 10 years ago

You are welcome !