search

fabiobiondi / angular-fullscreen

AngularJS HTML5 Fullscreen
214 stars 107 forks source link

pressing ESC does not call the function goFullscreen() while exiting #53

Closed Rafi993 closed 7 years ago

Rafi993 commented 7 years ago

Pressing ESC does not call goFullscreen() function when in fullscreen. But the function gets triggerd when the element is clicked. I wanted a small element to occupy fullscreen when clicked but It did not occupy the whole witdh and height of the screen so I used the function to set class. But since ESC is not triggered the set class does not get unset when ESC is pressed but it does when the button is pressed

Rafi993 commented 7 years ago

even though the function was not tirggred it did find a workaround by always setting the height of the element that should go to fullscreen to 100% and placing it inside a div with restricted height.

goors commented 7 years ago

yes i can confirm goFullscreen is not called on esc. what waste of time.