fabiobiondi / angular-fullscreen

AngularJS HTML5 Fullscreen
213 stars 107 forks source link

Emitting from $rootScope #57

Open narthur157 opened 7 years ago

narthur157 commented 7 years ago

Maybe I'm not understanding something, but shouldn't the event be broadcasted rather than emitted? https://github.com/fabiobiondi/angular-fullscreen/blob/master/src/angular-fullscreen.js#L16

narthur157 commented 7 years ago

$emit - Dispatches an event name upwards through the scope hierarchy notifying the registered $rootScope.Scope listeners. https://docs.angularjs.org/api/ng/type/$rootScope.Scope

Seems like nobody will get notified by this