Open kelvinau opened 5 years ago
Chrome's webkitRequestFullscreen is changed in version 71 and it takes an object for the parameter instead. This is where the error occurs: https://github.com/fabiobiondi/angular-fullscreen/blob/119b7fbac911d154fd56ace38ebe3432475e8a20/src/angular-fullscreen.js#L34 Now it takes an option to control whether to show the navigation UI. https://developer.mozilla.org/en-US/docs/Web/API/Element/requestFullscreen
Simply not passing the parameter to webkitRequestFullscreen will resolve this, as keyboard availability is not supported anymore.
webkitRequestFullscreen
I understand that this repo is not maintained anymore, so I won't submit a PR. Just for anyone who's still using this legacy library.
Chrome's webkitRequestFullscreen is changed in version 71 and it takes an object for the parameter instead. This is where the error occurs: https://github.com/fabiobiondi/angular-fullscreen/blob/119b7fbac911d154fd56ace38ebe3432475e8a20/src/angular-fullscreen.js#L34 Now it takes an option to control whether to show the navigation UI. https://developer.mozilla.org/en-US/docs/Web/API/Element/requestFullscreen
Simply not passing the parameter to
webkitRequestFullscreenwill resolve this, as keyboard availability is not supported anymore.I understand that this repo is not maintained anymore, so I won't submit a PR. Just for anyone who's still using this legacy library.