search

fabiobrz / eap-microprofile-test-suite

a small standalone test suite for MicroProfile on WF/EAP
Apache License 2.0
0 stars 0 forks source link

Fix errors while building tooling-server-configuration due to the addition of the new container adapter #27

Closed fabiobrz closed 4 years ago

fabiobrz commented 4 years ago

Fixes https://github.com/fabiobrz/eap-microprofile-test-suite/issues/26

fabiobrz commented 4 years ago

Hi @spriadka, can you have a look? I noticed an error while building (tooling-server-configuration) was unable to decide which container adapter to use (hence adding *-managed in the dependencies list) and the I skipped tests for it when D-ts.bootable is set because the tooling functionalities are verified against common server instance. BTW - I got the chance to perform that refactoring we discussed earlier - i.e. move some Dts.bootable configuration items up one level.

spriadka commented 4 years ago

Hi @fabiobrz, looking good. Could you also add skipping execution of initialize-basedirs execution of maven-antrun-plugin?, e.g 

<plugin>
                        <groupId>org.apache.maven.plugins</groupId>
                        <artifactId>maven-antrun-plugin</artifactId>
                        <executions>
                            <execution>
                                <id>rename-unpacked-jboss-as</id>
                                <goals>
                                    <goal>run</goal>
                                </goals>
                                <phase>none</phase>
                            </execution>
                            <execution>
                                <id>initialize-basedirs</id>
                                <goals>
                                    <goal>run</goal>
                                </goals>
                                <phase>none</phase>
                            </execution>
                        </executions>
                    </plugin>
fabiobrz commented 4 years ago

Hi @fabiobrz, looking good. Could you also add skipping execution of initialize-basedirs execution of maven-antrun-plugin?, e.g

<plugin>
                        <groupId>org.apache.maven.plugins</groupId>
                        <artifactId>maven-antrun-plugin</artifactId>
                        <executions>
                            <execution>
                                <id>rename-unpacked-jboss-as</id>
                                <goals>
                                    <goal>run</goal>
                                </goals>
                                <phase>none</phase>
                            </execution>
                            <execution>
                                <id>initialize-basedirs</id>
                                <goals>
                                    <goal>run</goal>
                                </goals>
                                <phase>none</phase>
                            </execution>
                        </executions>
                    </plugin>

Hi @spriadka - thanks for your review, done it.

spriadka commented 4 years ago

Thanks @fabiobrz, from my point of view, the MR is ready to be merged

fabiobrz commented 4 years ago

Thanks @fabiobrz, from my point of view, the MR is ready to be merged

Thanks @spriadka, merging.