fabiocaccamo / django-colorfield

:art: color field for django models with a nice color-picker in the admin.
MIT License
632 stars 95 forks source link

[`Enhancement`] : Add django 4.2 support #119

Closed baseplate-admin closed 1 year ago

baseplate-admin commented 1 year ago

name: Pull request about: Add support for django 4.2 assignees: fabiocaccamo


Describe your changes This Pull Request aims to add support for django 4.2

Related issue ?

Checklist before requesting a review

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (1fdb0a4) 88.35% compared to head (194406b) 88.35%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #119 +/- ## ======================================= Coverage 88.35% 88.35% ======================================= Files 7 7 Lines 146 146 ======================================= Hits 129 129 Misses 17 17 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `88.35% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Fabio+Caccamo#carryforward-flags-in-the-pull-request-comment) to find out more. Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Fabio+Caccamo). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Fabio+Caccamo)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

baseplate-admin commented 1 year ago

Ahhh it seems me and @fabiocaccamo was on same thought Process today.

Thanks for adding django 4.2 support

fabiocaccamo commented 1 year ago

@baseplate-admin I was adding Django 4.2 support to all my Django packages at once and I saw your PR only later, sorry.

baseplate-admin commented 1 year ago

I saw your PR only later, sorry.

Ah no worries mate, I am a fan of your packages ( you rock )