fabiocaccamo / django-colorfield

:art: color field for django models with a nice color-picker in the admin.
MIT License
632 stars 95 forks source link

Fix `ColorField` in RGB/RGBA format with `image_field` #154

Closed browniebroke closed 1 year ago

browniebroke commented 1 year ago

name: Pull request about: Submit a pull request for this project assignees: fabiocaccamo


Describe your changes Fix error when using image_field with RGB and RGBA formats

Related issue Fix #153

Checklist before requesting a review

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.36% :tada:

Comparison is base (57e5f01) 88.05% compared to head (98eefc1) 88.41%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #154 +/- ## ========================================== + Coverage 88.05% 88.41% +0.36% ========================================== Files 7 7 Lines 159 164 +5 ========================================== + Hits 140 145 +5 Misses 19 19 ``` | [Flag](https://app.codecov.io/gh/fabiocaccamo/django-colorfield/pull/154/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Fabio+Caccamo) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/fabiocaccamo/django-colorfield/pull/154/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Fabio+Caccamo) | `88.41% <100.00%> (+0.36%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Fabio+Caccamo#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files Changed](https://app.codecov.io/gh/fabiocaccamo/django-colorfield/pull/154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Fabio+Caccamo) | Coverage Δ | | |---|---|---| | [colorfield/fields.py](https://app.codecov.io/gh/fabiocaccamo/django-colorfield/pull/154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Fabio+Caccamo#diff-Y29sb3JmaWVsZC9maWVsZHMucHk=) | `91.78% <100.00%> (-0.12%)` | :arrow_down: | | [colorfield/utils.py](https://app.codecov.io/gh/fabiocaccamo/django-colorfield/pull/154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Fabio+Caccamo#diff-Y29sb3JmaWVsZC91dGlscy5weQ==) | `90.90% <100.00%> (+3.40%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.