fabiocaccamo / python-codicefiscale

:it: :credit_card: italian fiscal codes encoding, decoding and validation - codifica, decodifica e validazione del Codice Fiscale italiano.
MIT License
74 stars 24 forks source link

Issue with Incorrect Validation of Valid 'Codice Fiscale' #162

Closed dannylessio closed 9 months ago

dannylessio commented 9 months ago

Python version 3.11.2

Package version 0.9.1

Current behavior (bug description) I've encountered an issue with the library's validation function, where it incorrectly marks a certain Italian "codice fiscale" as invalid. The "codice fiscale" in question is validated correctly on the official website of the Italian "Agenzia delle Entrate."

Expected behavior The library should validate this pattern as it aligns with the format deemed valid by the "Agenzia delle Entrate".

Upvote & Fund

Fund with Polar

dannylessio commented 9 months ago

Since the matter involves a real "codice fiscale," which is sensitive personal information, I would like to share the specific details privately to avoid any data exposure. Could you please provide a secure method of communication (such as a private email address or a private issue tracker) where I can share the affected "codice fiscale"? This will help in replicating and addressing the validation issue without compromising personal privacy.

Many thanks

fabiocaccamo commented 9 months ago

@dannylessio thanks for reporting this issue and for funding it! You can send the code to my private email address: fabio.caccamo@gmail.com

fabiocaccamo commented 9 months ago

@dannylessio the cause of problem you reported is the same of #113 and #123.

Keeping the municipalities-patch.json list updated is complicated, not to mention that other issues of this nature could emerge in the future.

For this reasons I tried to find a permanent solution in #163

fabiocaccamo commented 9 months ago

@dannylessio you can upgrade to 0.10.0 version.

dannylessio commented 9 months ago

@fabiocaccamo awesome, many thanks!