fabiocaccamo / python-codicefiscale

:it: :credit_card: italian fiscal codes encoding, decoding and validation - codifica, decodifica e validazione del Codice Fiscale italiano.

MIT License

74 stars 23 forks source link

requirements: Accept python-dateutil<2.9.0 #6

Closed dbaty closed 5 years ago

dbaty commented 5 years ago

The current version of python-codicefiscale requires version <2.8 of python-dateutil. A version 2.8.0 has been released a few days ago and tests seem to pass with that version (and the changelog of python-dateutil 2.8.0 seems reasonable). Do you think that we could update the requirement?

fabiocaccamo commented 5 years ago

Sure, if CI build will pass all tests.

dbaty commented 5 years ago

If this change is fine, a new release of python-dateutil would be greatly appreciated. Some other libraries that depend on python-dateutil do not set any constraint and that may clash with the constraint set by python-codicefiscale. Thanks. :)

codecov[bot] commented 5 years ago

Codecov Report

Merging #6 into master will not change coverage. The diff coverage is n/a.

@@          Coverage Diff          @@
##           master     #6   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           3      3           
  Lines         185    185           
=====================================
  Hits          185    185

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 67afd05...4d5a474. Read the comment docs.

fabiocaccamo commented 5 years ago

If this change is fine, a new release of python-dateutil would be greatly appreciated. Some other libraries that depend on python-dateutil do not set any constraint and that may clash with the constraint set by python-codicefiscale. Thanks. :)

Do you mean a new release of python-codicefiscale? :)

fabiocaccamo commented 5 years ago

@dbaty you can update to 0.3.4 version.

fabiocaccamo commented 5 years ago

@dbaty why don't you star projects you use?

dbaty commented 5 years ago

@fabiocaccamo : thanks a lot, I did not expect such a fast response. :)

As for stars: I don't use GitHub social features such as stars or following users. It's not useful to me. It may be useful to repository owners, I don't know. I certainly don't select repositories based on the number of stars and followers. Others may do and I may be an idiot. I think that there are other numbers that are more interesting, e.g. the number of downloads on PyPI. They may be skewed but I don't think that stars are more reliable: how do users maintain a list of hundreds or thousands of starred repos? Do they regularly check that they still use, like or recommend each repo? I must be missing something.

I am sorry if me not starring your repository seems impolite to you. I usually find other ways to give back.

Thanks again for making this package open source and for your very fast support.

fabiocaccamo commented 5 years ago

I understand what you mean, no problem, don't worry. Personally I think that stars are useful to quick filter the results about what you are looking for on GitHub, after that you will do many other checks...

I will add a pypi downloads badge :)