IE9+ compatibility - Githubissues

fabiocaseri / dashing-js

Port of Dashing to node.js

MIT License

319 stars 151 forks source link

IE9+ compatibility #15

Closed arabold closed 10 years ago

arabold commented 10 years ago

Added dependency to Yaffle's EventSource polyfill
Send 2kb padding for IE < 10 compatibility
Replaced @constructor.name with custom method

adrianlee commented 10 years ago

Works great on IE10&11. Don't have IE9 but I assume the 2kb padding should work as per the README to Yaffle's EventSource.

arabold commented 10 years ago

I've tested it on IE9 as well and worked fine for me, too. Whether the padding is necessary or not, I don't really know. It would be great if you could test without and see if it makes any difference - my PC I'm working on right now has Sophos Antivirus installed which influences the EventSource. So I don't have reliable results.

adrianlee commented 10 years ago

I had took off the padding and my team's dashboard has been running in IE both 10 & 11 without problem in terms of receiving event data. No one here has IE9... I have been fixing a few bugs with widgets which were broken for IE.