search

fabiocolacio / Marker

🖊 A gtk3 markdown editor
GNU General Public License v3.0
836 stars 75 forks source link

(Do not) use GNOME appmenu depending on the DE #233

Closed maoschanz closed 5 years ago

maoschanz commented 6 years ago

with gtk_application_prefers_appmenu it's possible to know it the user want an appmenu without adding a setting

This is not an issue i actually ask you to fix, actually i've a patch on my disk rn i'll commit it maybe tomorrow, i just want to mention an issue in the commit

alice-mkh commented 6 years ago

Is it needed considering GNOME is moving away from appmenu as well? https://gitlab.gnome.org/GNOME/Initiatives/wikis/App-Menu-Retirement

maoschanz commented 6 years ago

Yes it's literally what my fork was originally about (however i'm doing other minor things on it too, the pull request will be ready in a few days if i'm not lazy, and should fix 3 issues)

It's distributed mainly as a Flatpak, so i think it's important to support Debian Stable users (3.22) and Ubuntu LTS users (3.28) too. So instead of using the current setting (which is not very nice because it duplicates the Tweaks one), i'm using that method which asks the environment if it wants an appmenu. Every DE (except GNOME Shell < 3.32 if users didn't change the setting in Tweaks) will answer false so everything will be in the hamburger, and users of older versions of GNOME will still have a consistent user experience since it will answer true and load an appmenu.

alice-mkh commented 6 years ago

Actually, true, I think the new GNOME versions will just answer false and it will just work \o/

On another note, I've updated the hamburger layout with this option disabled to match the initiative: https://github.com/fabiocolacio/Marker/pull/239/commits/3077a2f117e4a6e88b19515a5058de1dac216bc7