Closed maoschanz closed 6 years ago
Hi @maoschanz,
Thanks for you contributions, these are all great, and this fixes some long-standing issues with Marker. I cannot overstate how appreciative I am.
With that being said, please break this up into separate pull requests for each feature. That makes it much easier for me to test each feature separately, and request changes to them independently from each other as needed.
Please submit the Appmenu, Translations, Help, and the other UI changes as 4 separate pull requests.
Sorry i read CONTRIBUTING.md too late, so i will give more details about what i did:
Use the system-wide setting concerning the appmenu
Issue #233, people who can't have or don't want the appmenu will not have it automatically. Files changed are:
Translations
Issues #82 and #241, all the gettext thing should work, i also provided the french translation. Files changed are:
po
Help
Issue #86, but i'm not a native english speaker and i don't use Mermaid and Charter so you might like to write more accurate and complete help pages. Files changed are:
help
IMO, screenshots with more little windows should be used, currently it's hard to choose between huge pictures and tiny characters
Other things
src/resources/ui/marker-gear-popover.ui
andsrc/marker-editor.c
)src/resources/ui/marker-gear-popover.ui
should conflict with what @Exalm did concerning the "About" itemsrc/resources/ui/marker-prefs-window.ui
because everything was very compact